catch rlp exception: debug_traceBlock #7204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaszRozmej
approved these changes
Jun 20, 2024
|
Can you take a look also what happens in debug_traceBlockByNumber and debug_traceBlockByHash on genesis block? |
I'm getting similar errors , I added exception for them as well {
"jsonrpc": "2.0",
"error": {
"code": -32603,
"message": "Internal error",
"data": "System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation.\n ---> System.ArgumentNullException: Value cannot be null. (Parameter 'block')\n at System.ArgumentNullException.Throw(String paramName)\n at System.ArgumentNullException.ThrowIfNull(Object argument, String paramName)\n at Nethermind.Consensus.Tracing.GethStyleTracer.TraceBlock(Block block, GethTraceOptions options, CancellationToken cancellationToken) in /_/src/Nethermind/Nethermind.Consensus/Tracing/GethStyleTracer.cs:line 196\n at Nethermind.JsonRpc.Modules.DebugModule.DebugRpcModule.debug_traceBlockByHash(Hash256 blockHash, GethTraceOptions options) in /_/src/Nethermind/Nethermind.JsonRpc/Modules/DebugModule/DebugRpcModule.cs:line 190\n at InvokeStub_IDebugRpcModule.debug_traceBlockByHash(Object, Span`1)\n at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)\n --- End of inner exception stack trace ---\n at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)\n at Nethermind.JsonRpc.JsonRpcService.ExecuteAsync(JsonRpcRequest request, String methodName, ResolvedMethodInfo method, JsonRpcContext context) in /_/src/Nethermind/Nethermind.JsonRpc/JsonRpcService.cs:line 169"
},
"id": 1
} |
Comment on lines
+178
to
+181
| catch (ArgumentNullException) | ||
| { | ||
| return ResultWrapper<IReadOnlyCollection<GethLikeTxTrace>>.Fail($"Couldn't find any block", ErrorCodes.InvalidInput); | ||
| } |
There was a problem hiding this comment.
I think this can't happen here as it is RLP
There was a problem hiding this comment.
It can be inside the TraceBlock function
src/Nethermind/Nethermind.JsonRpc/Modules/DebugModule/DebugRpcModule.cs
Outdated
Show resolved
Hide resolved
LukaszRozmej
approved these changes
Jun 21, 2024
MarekM25
reviewed
Jun 23, 2024
In case of genesis block, the results are {
"jsonrpc": "2.0",
"result": [],
"id": 1
}for both the cases. And, for |
MarekM25
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7195
Please choose one of the keywords above to refer to the issue this PR solves followed by the issue number (e.g. Fixes #000). If no issue number, remove the line. Also, remove everything marked optional that is not applicable. Remove this note after reading.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Optional. Remove if not applicable.
Documentation
Requires documentation update
If yes, link the PR to the docs update or the issue with the details labeled
docs. Remove if not applicable.Requires explanation in Release Notes
If yes, fill in the details here. Remove if not applicable.
Remarks
Optional. Remove if not applicable.